Require CMake 3.17, remove CMP0051#7287
Merged
llvm-beanz merged 1 commit intomicrosoft:mainfrom Apr 1, 2025
Merged
Conversation
Hopefully this works and gets us able to build with CMake 4+.
damyanp
approved these changes
Apr 1, 2025
pow2clk
approved these changes
Apr 1, 2025
Collaborator
pow2clk
left a comment
pow2clk
left a comment
There was a problem hiding this comment.
This was inherited from LLVM 3.7. There's no reason to think we need it here if everything builds without it.
tex3d
reviewed
Apr 1, 2025
| cmake_policy(SET CMP0051 OLD) | ||
| endif() | ||
|
|
||
| if(CMAKE_VERSION VERSION_LESS 3.1.20141117) |
Contributor
There was a problem hiding this comment.
Existing issue note: is it possible for if(CMAKE_VERSION VERSION_LESS 3.1.20141117) to be true with the cmake_minimum_required(VERSION 3.17.2) set at the top of this file?
tex3d
approved these changes
Apr 1, 2025
jeffnn
pushed a commit
to jeffnn/DirectXShaderCompiler
that referenced
this pull request
Apr 8, 2025
Hopefully this works and gets us able to build with CMake 4+. (cherry picked from commit 3035d31)
madebr
pushed a commit
to madebr/DirectXShaderCompiler
that referenced
this pull request
Jun 10, 2025
Hopefully this works and gets us able to build with CMake 4+. (cherry picked from commit 3035d31)
ErichDonGubler
pushed a commit
to erichdongubler-mozilla/DirectXShaderCompiler
that referenced
this pull request
Aug 7, 2025
Hopefully this works and gets us able to build with CMake 4+.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully this works and gets us able to build with CMake 4+.